[typespec-python] simplify eng#4399
Merged
Merged
Conversation
microsoft-github-policy-service
Bot
added
the
emitter:python
Collaborator
|
All changed packages have been documented.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
commit: |
Collaborator
|
You can try these changes here
|
This reverts commit 003f6d4.
Backmerge of hotfix release tcgc@0.69.0 from `release/may-2026` into `main`. This ensures the version bump and fixes are reflected in main.⚠️ **Rebase merge** this PR (do not squash). --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tadelesh <1726438+tadelesh@users.noreply.github.com> Co-authored-by: tadelesh <chenjieshi@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
lib:tcgc
msyyc
enabled auto-merge
June 2, 2026 08:10
tadelesh
approved these changes
Jun 8, 2026
l0lawrence
added a commit
that referenced
this pull request
Jun 30, 2026
Upstream PR #4399 moved/rewrote the python regenerate driver to eng/scripts/ci/regenerate.ts (in-process compilation). Re-apply the emitter-diff overrides on the new wrapper and point the adapter at it: - regenerate.ts: add --httpSpecsDir/--azureSpecsDir/--use-pyodide/--no-baseline options; thread use-pyodide into emitter task options; gate the azure-sdk-for-python baseline clone behind --no-baseline. All overrides live in the non-synced wrapper so regenerate-common.ts stays identical upstream. - python adapter: drive eng/scripts/ci/regenerate.ts with --pluginDir (emitter build) + --generatedFolder (output root, anchored so files land in <outputDir>/tests/generated); pin specs to the current checkout so only the emitter varies; pass --no-baseline. Update runTests sync source for the new nested layout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce duplication between
typespec-python(a thin wrapper) and upstream@typespec/http-client-pythonso we don't keep maintaining two copies of the same eng/test scaffolding by hand.Approach
eng/scripts/sync.ts— new allow-list mirror that copies a curated set of shared files from a sibling checkout (<repo-root>/core/packages/http-client-python/) into this package. Supports--checkfor CI drift detection.eng/scripts/ci/regenerate-common.ts— shared helpers / spec tables /prepareBaselineOfGeneratedCode, byte-identical with the upstream copy. Synced.eng/scripts/ci/regenerate.ts— kept per-repo: wrapper does single-phase in-process regen; upstream does two-phase. Imports common helpers, owns only paths/argv/orchestration.dev_requirements.txt— synced as a section (everything before the# additional dependency needed for developmentmarker is replaced from upstream; wrapper-only deps likesetuptoolsare preserved).run_apiview.py,run_mypy.py,run_pylint.py,run_pyright.py,run_sphinx_build.py,util.py, plusmypy.ini,pylintrc,pyrightconfig.json.tests/data/,tests/mock_api/,tests/requirements/,tests/conftest.py,tests/install_packages.py,tests/tox.ini, and thegenerator/(pygen) tree.eng/scripts/setup/*is intentionally not synced — the wrapper owns its own setup pipeline (install.py,prepare.py,venvtools.py, …).